Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POTENTIAL BREAKING CHANGE]: upgrading to aws sdk v3 and supporting sso configuration #82

Merged

Conversation

rajeshsusai
Copy link
Contributor

Checklist

If any of the items on this list can't be resolved independently, please
feel welcome to request assistance in the comments of the pull request.

  • scripts/validate-features runs successfully
  • PR is marked as ready for review (i.e. not a draft)

mattquinlan440
mattquinlan440 previously approved these changes Oct 15, 2024
Copy link
Contributor

@mattquinlan440 mattquinlan440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great update, and would definitely constitute a breaking change.

I think that this is good to merge, and we will finish updating the build pipeline so we can get this update out

Copy link
Contributor

@mattquinlan440 mattquinlan440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on this work!

With this, we can finally address #77 and #80

@rajeshsusai rajeshsusai merged commit cd4ea8b into master Oct 16, 2024
3 checks passed
@rajeshsusai rajeshsusai deleted the upgrade-to-aws-sdk-v3-and-read-from-ini-config-files branch October 16, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants